Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ExtractCloakMeshBlueprint which assumes Categories being called on a unit without Categories. #6281

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Fixed ExtractCloakMeshBlueprint which assumes Categories being called on a unit without Categories. #6281

merged 4 commits into from
Oct 12, 2024
+8 −2

Conversation

The-Balthazar
Copy link
Contributor

No description provided.

@MrRowey
Copy link
Member

MrRowey commented Jun 21, 2024 •
edited
Loading

@The-Balthazar can you please make sure that there is a description provided so I can be understood at a late date
https://github.com/FAForever/fa/blob/develop/.github/pull_request_template.md As the template shows you also require the snippet. See https://github.com/FAForever/fa/blob/develop/changelog/snippets/fix.6342.md for how it is done

@lL1l1
Copy link
Contributor

lL1l1 commented Oct 12, 2024

Reported on Discord.

Bug was in the original implementation of the extraction function.

Tested by removing the categories table from UEL0001 and making sure the blueprint loading phase passes successfully.

@lL1l1 lL1l1 merged commit c95b42a into FAForever:develop Oct 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lL1l1 lL1l1 lL1l1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-Balthazar @MrRowey @lL1l1