Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seraphim Sniper Bot: increase the StrategicIconSize of its secondary firing mode's projectile #6465

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented Sep 28, 2024

Description of the proposed changes

The current StrategicIconSize of this projectile is set to 1. This is too small, because the projectile is very fast and thereby easy to miss. A StrategicIconSize of 1 also does not represent the actual strength of the projectile well (2000 damage).

I changed the StrategicIconSize to 4 in this PR. Alternative and possibly preferable options could be:

  • Only increase it to 3 since 4 is only used by TML missiles.
  • Decrease the StrategicIconSize of the first firing mode to 2 and and only increase the size of the second firing mode to 3.

Checklist

  • Changes are documented in the changelog for the next game version

@Basilisk3 Basilisk3 added the feature: strategic icons related to strategic icons label Sep 28, 2024
@lL1l1
Copy link
Contributor

lL1l1 commented Oct 12, 2024

Comparison from left to right of percivals, bricks (both size 2), normal sniper shots (size 3), and sniper sniper shots (size 4).

{165CC18A-52DB-411F-843A-F502A43C6C75}

I think for how high velocity and high damage the projectiles are, it's fine to use the unique size 4 icon. You could argue that normal shots should be size 2 and then size 3 for sniper shots, but I think the argument against that is that the high velocity and long range needs a larger size to be noticed in contrast to the slow/short range percy/brick projectiles.

By the way, Othuums have size 1 projectiles for both weapons. The Thau Cannon could have size 2. Also the Thau cannon is listed as indirect fire in the UI, although indirect fire range rings + direct fire UI text is possible.

@lL1l1
Copy link
Contributor

lL1l1 commented Oct 12, 2024

In particular for this type of view the size is even more important:
{37722837-9A88-44C8-B35F-FEB0E6C827FA}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: strategic icons related to strategic icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants