Minor fixes before making an official V1.0 release #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterBaker0
approved these changes
Dec 10, 2024
Comment on lines
+211
to
+212
| const [start, setStart] = useState<number | string>(props.range.start); | ||
| const [stop, setStop] = useState<number | string>(props.range.stop); |
There was a problem hiding this comment.
do they really need to be a number or a string? Might be better to on each render parse the value as a number - just choose one?
There was a problem hiding this comment.
This is to allow for the empty string, if I don't, you can't delete the number that's there to enter a new one. Note this is only for the field value, not for the final data structure which is a number.
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
Now fixed in another PR. Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
stevecassidy
force-pushed
the
pre-release-v1-fixes
branch
from
0ca4472 to
9299089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes before making an official V1.0 release
JIRA Ticket
None
Description
Just fixing up any minor things before finalising the 1.0.0 release.
Proposed Changes
How to Test
Check that all of the above are working well on mobile.
Checklist