Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: map location 🗺️ #1253

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions app/src/gui/components/map/center-control.tsx

This file was deleted.

66 changes: 10 additions & 56 deletions app/src/gui/components/notebook/overview_map.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,18 @@ import GeoJSON from 'ol/format/GeoJSON';
import TileLayer from 'ol/layer/Tile';
import VectorLayer from 'ol/layer/Vector';
import Map from 'ol/Map';
import {transform} from 'ol/proj';
import {OSM} from 'ol/source';
import VectorSource from 'ol/source/Vector';
import {Fill, RegularShape, Stroke, Style} from 'ol/style';
import {Fill, Stroke, Style} from 'ol/style';
import CircleStyle from 'ol/style/Circle';
import {useCallback, useMemo, useRef, useState} from 'react';
import {Link} from 'react-router-dom';
import * as ROUTES from '../../../constants/routes';
import {createCenterControl} from '../map/center-control';
import {Geolocation} from '@capacitor/geolocation';
import {addCenterControl} from '../../../lib/map/center-control';
import {
addCurrentLocationMarker,
getCurrentLocation,
} from '../../../lib/map/current-location';

interface OverviewMapProps {
uiSpec: ProjectUIModel;
Expand Down Expand Up @@ -140,13 +142,7 @@ export const OverviewMap = (props: OverviewMapProps) => {
const mapRef = useRef<Map | undefined>();
mapRef.current = map;

const {data: map_center, isLoading: loadingLocation} = useQuery({
queryKey: ['current_location'],
queryFn: async (): Promise<[number, number]> => {
const position = await Geolocation.getCurrentPosition();
return [position.coords.longitude, position.coords.latitude];
},
});
const {data: currentLocation} = getCurrentLocation();

/**
* Create the OpenLayers map element
Expand Down Expand Up @@ -182,43 +178,6 @@ export const OverviewMap = (props: OverviewMapProps) => {
*
* @param map the map element
*/
const addCurrentLocationMarker = (map: Map) => {
const source = new VectorSource();
const geoJson = new GeoJSON();

const stroke = new Stroke({color: 'black', width: 2});
const layer = new VectorLayer({
source: source,
style: new Style({
image: new RegularShape({
stroke: stroke,
points: 4,
radius: 10,
radius2: 0,
angle: 0,
}),
}),
});

// only do this if we have a real map_center
if (map_center) {
const centerFeature = {
type: 'Feature',
geometry: {
type: 'Point',
coordinates: map_center,
},
};

source.addFeature(
geoJson.readFeature(centerFeature, {
dataProjection: 'EPSG:4326',
featureProjection: map.getView().getProjection(),
})
);
map.addLayer(layer);
}
};

/**
* Add the features to the map and set the map view to
Expand Down Expand Up @@ -263,14 +222,9 @@ export const OverviewMap = (props: OverviewMapProps) => {
map.addLayer(layer);
};

// when we have a location and a map, add the 'here' marker to the map
if (!loadingLocation && map) {
addCurrentLocationMarker(map);
if (map_center) {
const center = transform(map_center, 'EPSG:4326', defaultMapProjection);
// add the 'here' button to go to the current location
map.addControl(createCenterControl(map.getView(), center));
}
if (map && currentLocation) {
addCurrentLocationMarker(map, currentLocation);
addCenterControl(map, currentLocation);
}

// when we have features, add them to the map
Expand Down
21 changes: 15 additions & 6 deletions app/src/gui/fields/maps/MapWrapper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* Description:
* Internals of map generation for MapFormField
*/
import React, {useState, useRef, useCallback} from 'react';
import {useState, useRef, useCallback, useEffect} from 'react';

// openlayers
import Map from 'ol/Map';
Expand Down Expand Up @@ -67,8 +67,12 @@ interface MapProps extends ButtonProps {
import {AppBar, Dialog, IconButton, Toolbar, Typography} from '@mui/material';
import Feature from 'ol/Feature';
import {Geometry} from 'ol/geom';
import {createCenterControl} from '../../components/map/center-control';
import {addCenterControl} from '../../../lib/map/center-control';
import {useNotification} from '../../../context/popup';
import {
addCurrentLocationMarker,
getCurrentLocation,
} from '../../../lib/map/current-location';

const styles = {
mapContainer: {
Expand All @@ -88,6 +92,15 @@ function MapWrapper(props: MapProps) {
const defaultMapProjection = 'EPSG:3857';
const geoJson = new GeoJSON();

const {data: currentLocation} = getCurrentLocation();

useEffect(() => {
if (map && currentLocation) {
addCenterControl(map, currentLocation);
addCurrentLocationMarker(map, currentLocation);
}
}, [map, currentLocation]);

// notifications
const notify = useNotification();

Expand Down Expand Up @@ -142,10 +155,6 @@ function MapWrapper(props: MapProps) {
controls: [new Zoom()],
});

theMap.addControl(createCenterControl(theMap.getView(), center));

theMap.getView().setCenter(center);

return theMap;
},
[]
Expand Down
35 changes: 35 additions & 0 deletions app/src/lib/map/center-control.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import {Control} from 'ol/control';
import {Coordinate} from 'ol/coordinate';
import Map from 'ol/Map';
import {CreateDomIcon} from '../../gui/components/map/dom-icon';
import src from '../../target.svg';
import {transform} from 'ol/proj';

export const addCenterControl = (map: Map, coords: Coordinate) => {
const element = document.createElement('div');
element.className = 'ol-center-box';

const button = document.createElement('button');
button.className = 'ol-center-button';

button.appendChild(
CreateDomIcon({
src,
width: 24,
height: 24,
alt: 'Center map',
})
);

button.addEventListener('click', () => {
map.getView().setCenter(transform(coords, 'EPSG:4326', 'EPSG:3857'));
});

element.appendChild(button);

map.addControl(
new Control({
element: element,
})
);
};
60 changes: 60 additions & 0 deletions app/src/lib/map/current-location.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import GeoJSON from 'ol/format/GeoJSON';
import VectorSource from 'ol/source/Vector';
import Map from 'ol/Map';
import VectorLayer from 'ol/layer/Vector';
import {Fill, Style} from 'ol/style';
import CircleStyle from 'ol/style/Circle';
import {useQuery} from '@tanstack/react-query';
import {Geolocation} from '@capacitor/geolocation';

export const getCurrentLocation = () =>
useQuery({
queryKey: ['current_location'],
queryFn: async (): Promise<[number, number]> => {
const {
coords: {longitude, latitude},
} = await Geolocation.getCurrentPosition();
return [longitude, latitude];
},
});

export const addCurrentLocationMarker = (
map: Map,
coordinates: [number, number]
) => {
const source = new VectorSource();

source.addFeature(
new GeoJSON().readFeature(
{
type: 'Feature',
geometry: {
type: 'Point',
coordinates,
},
},
{
dataProjection: 'EPSG:4326',
featureProjection: map.getView().getProjection(),
}
)
);

for (const {radius, color} of [
{radius: 14, color: 'rgba(59, 130, 246, 0.1)'},
{radius: 8, color: 'rgb(255, 255, 255)'},
{radius: 6, color: 'rgb(59, 130, 246)'},
]) {
map.addLayer(
new VectorLayer({
source: source,
style: new Style({
image: new CircleStyle({
radius,
fill: new Fill({color}),
}),
}),
})
);
}
};
Loading