Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: offline projects list 🐛 #1254

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: offline projects list 🐛 #1254

merged 2 commits into from
Dec 11, 2024

Conversation

luke-mcfarlane-rocketlab
Copy link
Contributor

@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab commented Dec 11, 2024 •
edited
Loading

JIRA Ticket

BSS-548

Description

Projects list not working while offline.

Proposed Changes

  • Added function to update local database with projects list on both sync and init

How to Test

  1. Ensure the projects list works without internet

Additional Information

I believe the context provider was already pulling in the local projects it was just empty as the update local function was lost in an update.

Checklist

  • I have confirmed all commits have been signed.
  • I have added JSDoc style comments to any new functions or classes.
  • Relevant documentation such as READMEs, guides, and class comments are updated.

@luke-mcfarlane-rocketlab
Updated context provider to store projects locally
4b77e26 
Signed-off-by: Luke McFarlane <luke.mcfarlane@rocketlab.com.au>
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab changed the title Updated context provider to store projects locally fix: offline projects list Dec 11, 2024
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab changed the title fix: offline projects list fix: offline projects list 🐛 Dec 11, 2024
@stevecassidy
don't crash when offline and fetching projects
1ddbab2 
Signed-off-by: Steve Cassidy <steve.cassidy@mq.edu.au>
stevecassidy
stevecassidy approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@stevecassidy stevecassidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still got no projects with your change, added a catch in getProjects to guard against being offline and it works ok for me now when offline. Thanks.

@luke-mcfarlane-rocketlab
Copy link
Contributor Author

I still got no projects with your change, added a catch in getProjects to guard against being offline and it works ok for me now when offline. Thanks.

Thanks for applying the fix!

@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab marked this pull request as ready for review December 11, 2024 22:16
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab merged commit 4218a2d into main Dec 11, 2024
2 checks passed
@luke-mcfarlane-rocketlab luke-mcfarlane-rocketlab deleted the fix/offline-projects-list branch December 11, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevecassidy stevecassidy stevecassidy approved these changes

@PeterBaker0 PeterBaker0 Awaiting requested review from PeterBaker0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luke-mcfarlane-rocketlab @stevecassidy