-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: servers, projects, dbs, activation and deactivation, metadata overhaul #1347
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
…dependency Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
…edux store should not directly hold non-serializable instances. Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
…etween app vs api storage Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
… with force Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
…chments - clarify naming Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glorious! Well done. Only serious concern is about deleting databases on deactivation. A few minor comments.
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
…th Object.values Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Tests fine on IOS - no problem pointing it to existing server. One final suggestion - a confirmation dialog on deactivation might be good to prevent accidental button pushes. |
feat: servers, projects, dbs, activation, metadata overhaul
Description
Completely overhauls the app's handling of
Does this by building from the ground up a redux-store slice named 'projects' which manages all of this.
It does this through a combination of
Uses redux-persist to store data in local storage (works on all platforms). Expands the initialisation gate to safely dispatch all restore ops (e.g. generating DBs based on config, compiling UI specs) before the app loads.
Removes all DB sync/events logic - this could have implications for one spot I could see which is the auto head merging occurring to presumably minimise conflicts(?). I tested conflicts and it still seemed to work - so unsure what this actually does.
Also did a bunch of misc tidy up while deep in the code, including stripping out the annoying 'split project' vs 'unique project' etc etc which is not necessary - the app now knows which server a project refers to in all places and where only a project ID was available, I supplemented the routes to include the server ID.
Removes the metadata-db (there was no need for this to be a database, its just a static set of key value pairs which are one way sync'd from the API).
New features
TODO
return <></>
with a suitable real return valueHow to Test
Test the entire app! There will be bugs.
Checklist