-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCalculator to FAIRChemCalculator #722
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HabibOmar, if you can change imports to use the convenience import from fairchem.core import FAIRChemCalculator
were applicable that would be great!
Hi @lbluque, I have addressed the requested changes and resolved the conversation. Please review the updates when you have a chance and let me know if there is something else that needs to be changed. Thank you! |
Hi @HabibOmar Thanks for this. It would be nice to add backwards compatibility for fairchem/src/fairchem/core/datasets/lmdb_dataset.py Lines 227 to 234 in 5743a59
We can deprecate this in a future release once more people are familiar with the transition. Also - |
Changed all occurrences of OCPCalculator to FAIRChemCalculator.