Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General loss and metrics functions #821

Closed
wants to merge 12 commits into from
Closed

General loss and metrics functions #821

wants to merge 12 commits into from

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Aug 22, 2024 •
edited
Loading

Enables using different loss and metrics functions, such as per atom loss.

@lbluque lbluque requested a review from wood-b August 22, 2024 18:22
@lbluque lbluque added enhancement New feature or request minor Minor version release labels Aug 22, 2024
@lbluque lbluque marked this pull request as draft August 22, 2024 18:22
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.24528% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/modules/loss.py 56.25% 7 Missing ⚠️
src/fairchem/core/common/utils.py 33.33% 2 Missing ⚠️
src/fairchem/core/modules/evaluator.py 93.54% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/trainers/ocp_trainer.py 69.66% <100.00%> (+0.30%) ⬆️
src/fairchem/core/common/utils.py 68.55% <33.33%> (-0.20%) ⬇️
src/fairchem/core/modules/evaluator.py 91.80% <93.54%> (-1.66%) ⬇️
src/fairchem/core/modules/loss.py 61.19% <56.25%> (-4.88%) ⬇️

@lbluque
Copy link
Collaborator Author

lbluque commented Oct 16, 2024

@wood-b @kyonofx is this ready?

@lbluque lbluque marked this pull request as ready for review October 18, 2024 11:34
@lbluque lbluque requested review from misko and kyonofx October 22, 2024 16:45
@wood-b wood-b mentioned this pull request Oct 25, 2024
Merged
3 tasks
@lbluque
Copy link
Collaborator Author

lbluque commented Oct 30, 2024

Closing, since this was superseded by #896

@lbluque lbluque closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wood-b wood-b Awaiting requested review from wood-b

@misko misko Awaiting requested review from misko

@kyonofx kyonofx Awaiting requested review from kyonofx

Assignees
No one assigned
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbluque @kyonofx @wood-b