move escn to deprecated #851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
lbluque
reviewed
Sep 13, 2024
| from e3nn import o3 | ||
|
|
||
|
|
||
| @registry.register_model("escn") |
There was a problem hiding this comment.
Id suggest using @deprecated from typing_extenstions to show a warning message when we deprecate things.
rayg1234
reviewed
Sep 13, 2024
| @@ -139,8 +139,12 @@ def __init__( | |||
|
|
|||
| # Initialize the transformations between spherical and grid representations | |||
| self.SO3_grid = nn.ModuleDict() | |||
| self.SO3_grid["lmax_lmax"] = SO3_Grid(self.lmax, self.lmax, resolution=resolution) | |||
| self.SO3_grid["lmax_mmax"] = SO3_Grid(self.lmax, self.mmax, resolution=resolution) | |||
| self.SO3_grid["lmax_lmax"] = SO3_Grid( | |||
There was a problem hiding this comment.
are we using different linters? lol, ive been manually calling ruff ...
rayg1234
reviewed
Sep 13, 2024
| atomic_numbers = data.atomic_numbers.long() | ||
| assert ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.