-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vamas sub-reader: enhance data extraction, add IRREGULAR parsing #10
Vamas sub-reader: enhance data extraction, add IRREGULAR parsing #10
Conversation
…nhance-data-extraction
Pull Request Test Coverage Report for Build 8294709433Details
💛 - Coveralls |
Here are the some change requests. |
3ac7f2a
to
4c26b37
Compare
Sorry for the confusion. I reviewed some code on the first review but some of them submitted and some of them I did not submit. So, now you see new change requests. Which I am going to resolve now. I think there a few comment you may add in the future especially pynxtools_xps/vms/vamas.py where you assumed all the data will come in a chain. But if one of them is broken or missing other fields will read the wrong data. So in another PR you can take care of it. |
There is really no other way around then reading the data in a list. The Vamas format does not allow for keywords in the file and it alway assumes that all of the elements are at the correct positions (it is an ISO standard afterall, so if you don't have the right structure, it cannot be a vamas file). |
This enhances the capabilities of the existing Vamas XPS reader.
The Vamas reader reads .vms files, which is the current ISO standard data transfer format (ISO 14976).
VMS specific:
General: