-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix example #103
fix example #103
Conversation
Reviewer's Guide by SourceryThis PR updates the XPS data schema and documentation to align with the NXxps application definition, improves naming conventions, adds proper units to quantities, and reorganizes the documentation structure. The changes primarily focus on schema refinements and documentation clarity. Updated ER diagram for XPS ELN data schemaerDiagram
XPS {
STRING name
STRING base_sections
STRING m_annotations
}
XPS ||--o{ user : has
user {
STRING affiliation
STRING orcid
}
XPS ||--o{ instrument : has
instrument {
STRING device_information
STRING energy_resolution
STRING source_xray
}
XPS ||--o{ sample : has
sample {
STRING substance
FLOAT molecular_mass "g/mol"
}
sample ||--o{ history : has
history {
STRING sample_preparation
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lukaspie - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
||
Below, you find an overview of your uploaded data. | ||
Click on the `> /` button to get a list of your data or select **FILES** from the top menu of this upload. | ||
Click on the `> /` button to get a list of your file or select **FILES** from the top menu of this upload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): There appears to be a typo: 'list of your file' should be 'list of your files'
Click on the `> /` button to get a list of your file or select **FILES** from the top menu of this upload. | |
Click on the `> /` button to get a list of your files or select **FILES** from the top menu of this upload. |
Summary by Sourcery
Fix inconsistencies in the XPS ELN data schema by standardizing section names to lowercase and updating units for various quantities. Update documentation to reflect these changes and correct application definition references.
Bug Fixes:
Enhancements:
Documentation: