-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sub-reader for PHI Versaprobe data #5
Conversation
Pull Request Test Coverage Report for Build 8465335526Details
💛 - Coveralls |
6661351
to
b333a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some small things and my general confusion about the dict (whether this can be a config file). But probably there is a good reason this is separate from the config file which I just don't understand.
I tested it with the files from Sebastian and it all works well.
An additional consideration we already discussed in discord is adding an additional axis for the depth profile so you can view it in one NXdata. Depending on the effort this can either be handled here or in a separate PR.
Thanks for the implementation :)
I realized that this is a bit of an involved effort because the XPS reader so far only works for one-dimensional datasets with an energy axis. In principle, I think I should redesign it such that not every scan gets an axis in NXdata, but rather the scan numbers, measurement cycle numbers, sputter cycle numbers, are axes to one NXdata. However, this requires quite a bit of effort to disentangle in the main reader, so I suggest that I will do it in a separate PR. Thus, I would just simply wait for the approval that the example/test data can be included here and then it would merge this PR. |
Sounds reasonable. I'll approve this already. Feel free to add the test data and merge when ready |
Phi Parser:
Other changes:
Error fixes:
ENTRY[entry]
to the actual entries (e.g. `ENTRY[MeasurementGroup_Survey]) has been streamlined and harmonized across all subreadersStill missing:
This PR depends on FAIRmat-NFDI/pynxtools#220 and should be merged afterwards/together.
EDIT: FAIRmat-NFDI/pynxtools#220 merged into pynxools-xps@main.
Resolves #1.