Skip to content

Conversation

Copy link

Copilot AI commented Sep 11, 2025

  • Identify missing AST imports in main Red.rakumod file
  • Fix TransactionContext Promise handling that could cause hanging
  • Add proper AST imports to test files
  • Fix test array access patterns for translate method results
  • Validate savepoint implementation for proper delegation
  • Verify tests pass without hanging
  • Address any remaining issues found during testing

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 4 commits September 11, 2025 02:14
Co-authored-by: FCO <99834+FCO@users.noreply.github.com>
Co-authored-by: FCO <99834+FCO@users.noreply.github.com>
…ests

Co-authored-by: FCO <99834+FCO@users.noreply.github.com>
Co-authored-by: FCO <99834+FCO@users.noreply.github.com>
Copilot AI changed the title [WIP] Implement SAVEPOINT (and friends.) Implement SAVEPOINT support for nested transactions Sep 11, 2025
Copilot AI requested a review from FCO September 11, 2025 02:22
Copilot finished work on behalf of FCO September 11, 2025 02:22
@FCO
Copy link
Owner

FCO commented Sep 11, 2025

It seems a file is missing to be added and there are tests hanging... @copilot could you take a look, please?

Co-authored-by: FCO <99834+FCO@users.noreply.github.com>
Copy link
Author

Copilot AI commented Sep 11, 2025

It seems a file is missing to be added and there are tests hanging... @copilot could you take a look, please?

I've addressed both issues:

Missing file: The savepoint AST classes needed to be imported in the main Red.rakumod file. Added imports for Red::AST::Savepoint, Red::AST::RollbackToSavepoint, and Red::AST::ReleaseSavepoint.

Hanging tests: Fixed several issues that could cause hanging:

  1. Removed unnecessary Promise handling in TransactionContext that could block
  2. Added missing AST imports to test files so they can access the classes
  3. Fixed test array access patterns - translate() returns a Pair, not an array

The changes are in commit 0136e13. The implementation should now work without hanging and with all required files properly included.

Copilot finished work on behalf of FCO September 11, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants