Skip to content

Comments

Controller + metrics#7

Merged
FCastillo-pixel merged 23 commits intomainfrom
backend
Jun 23, 2025
Merged

Controller + metrics#7
FCastillo-pixel merged 23 commits intomainfrom
backend

Conversation

@FCastillo-pixel
Copy link
Owner

No description provided.

@github-actions
Copy link

Code Coverage

Overall Project 3.08% -96.25%
Files changed 2.71%

File Coverage
ProductController.java 10.34% -89.66%
ProductRepository.java 6.84% -93.16%
ProductService.java 2.49% -97.51%
ProductDTO.java 0%
Product.java 0%
InventoryMetrics.java 0%

@github-actions
Copy link

Code Coverage

Overall Project 22.76% -76.57%
Files changed 22.6%

File Coverage
ProductDTO.java 89.47% -10.53% 🍏
Product.java 44% -56%
ProductRepository.java 26.5% -73.5%
ProductService.java 21.58% -78.42%
ProductController.java 10.34% -89.66%
InventoryMetrics.java 0%

@github-actions
Copy link

Code Coverage

Overall Project 22.25% -77.09%
Files changed 22.09%

File Coverage
ProductDTO.java 89.47% -10.53% 🍏
Product.java 44% -56%
ProductRepository.java 26.5% -73.5%
ProductService.java 20.47% -79.53%
ProductController.java 9.68% -90.32%
InventoryMetrics.java 0%

@github-actions
Copy link

Code Coverage

Overall Project 20.26% -79.14%
Files changed 20.1%

File Coverage
ProductDTO.java 89.47% -10.53% 🍏
Product.java 44% -56%
ProductRepository.java 26.5% -73.5%
ProductService.java 16.99% -83.01%
ProductController.java 9.68% -90.32%
ProductPage.java 0%
InventoryMetrics.java 0%

@RequestMapping("/products")
@CrossOrigin(origins = "http://localhost:8080")
public class ProductController {
private final ProductService service;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a best practice, Service and DAO classes should depend on interfaces rather than concrete implementations to promote low coupling and flexibility.


@Service
public class ProductService {
private final ProductRepository repository;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a best practice, Service and DAO classes should depend on interfaces rather than concrete implementations to promote loose coupling and flexibility.

@github-actions
Copy link

Code Coverage

Overall Project 20.26% -79.14%
Files changed 20.1%

File Coverage
ProductDTO.java 89.47% -10.53% 🍏
Product.java 44% -56%
ProductRepository.java 26.5% -73.5%
ProductService.java 16.99% -83.01%
ProductController.java 9.68% -90.32%
ProductPage.java 0%
InventoryMetrics.java 0%

@FCastillo-pixel FCastillo-pixel merged commit 9b59b2a into main Jun 23, 2025
2 of 4 checks passed
@github-actions
Copy link

Code Coverage

Overall Project 20.26% -79.14%
Files changed 20.1%

File Coverage
ProductDTO.java 89.47% -10.53% 🍏
Product.java 44% -56%
ProductRepository.java 26.5% -73.5%
ProductService.java 16.99% -83.01%
ProductController.java 9.68% -90.32%
ProductPage.java 0%
InventoryMetrics.java 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants