[Feat/#210] 인사이트 API 연동 및 관련 훅/컴포넌트 리팩터링#314
Merged
Conversation
…heatmap queries
LDY981212
requested changes
Oct 25, 2025
src/hooks/useInsight.ts
Outdated
| export const useWeeklyInsight = (date: string) => { | ||
| return useQuery<ApiWeeklyInsightResponse>({ | ||
| queryKey: ['weeklyInsight', date], | ||
| queryFn: async () => getWeeklyInsight(date), |
Contributor
There was a problem hiding this comment.
queryFn에 getWeeklyInsight 함수가 이미 promise를 반환해주기 때문에 async를 제거해주는 것이 좋을 것 같습니다.
LDY981212
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈 번호 (Related Issue Number)
✨ PR 세부 내용 (PR Details)
작업 개요
주요 변경사항
getWeeklyInsight(date)getMonthlyInsight(yearMonth)opts?: { enabled?: boolean }추가, enabled: !!param && (opts?.enabled ?? true)로 조건 실행useWeeklyInsight(getCurrentDate(), { enabled: isWeek }),useMonthlyInsight(getCurrentMonth(), { enabled: !isWeek })로 탭 상태에 따라 활성화