-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when reference values do not resolve and have incorrect format #1468
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b2c2f16
Warn when reference values do not resolve and are not in correct form…
KaelynJefferson 3cda48c
additional check for fhir reference format, log when reference is not…
KaelynJefferson c463bde
update check for absolute url
KaelynJefferson 36a7162
Removing conditional for logging reference value with more/than/two/p…
KaelynJefferson 0b69980
update reference warn message, account for reference case of uuid or oid
KaelynJefferson 7247b48
combining conditional statements
KaelynJefferson 22f6a23
Merge branch 'master' into correct-format-reference
KaelynJefferson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way this logic is written with the nested if statements makes me think there's something else we want to do if the value starts with
urn:
but does contain a/
. I think it would be simpler to just have one if statement with both conditions combined with "and" (i.e.!value.reference.startsWith('urn:') && !value.reference.includes('/')
). While that doesn't change the logic as it currently is, I think it makes the intent a little clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or there is, of course, the equivalent inverse expression:
!(value.reference.startsWith('urn:') || value.reference.includes('/'))
. Take your pick!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De Morgan would be proud of this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right. That's his name!