-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution Policy #1470
Contribution Policy #1470
Conversation
Thanks, Julia. This looks great -- and I think that potential contributors will really appreciate it! I also like the Code of Conduct badge and tab. As for the location of the files, I prefer having them in the root directory of the project so that others easily notice them. Up until today, I wouldn't have thought of looking in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new code of conduct and contribution policy look good! Thank you!
@cmoesel and @mint-thompson: I made some small tweaks based on feedback from @KaelynJefferson. Let me know what you think. Also, I just wanted to call out two other thoughts to make sure we had considered:
|
@jafeltra HL7 has reviewed it and noted that we should use the HL7 Code of Conduct instead of the one we're currently pointing to. Please:
|
Just documenting what we discussed in our 1:1: It's sufficient to have the CODE-OF-CONDUCT file link to the HL7 Code of Conduct without copying all its text. |
@cmoesel - I just updated this PR with the feedback from HL7 and the approach you noted above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you, @jafeltra. At this point you can add variations of these to the remaining repos:
- GoFSH
- FHIR Package Loader
- FSH Online
- FSH Online Examples
- FSH School Site
- FSH VS Code Extension
Thanks!
Chris
* Add CONTRIBUTING.md and CODE-OF-CONDUCT.md with badge * Small tweaks * Use HL7 Code of Conduct
This PR adds a Contribution Policy for SUSHI. This includes a
CONTRIBUTING.md
file and aCODE-OF-CONDUCT.md
file.The Code of Conduct comes from https://www.contributor-covenant.org/. They mentioned there is a badge, so I added it, but it isn't required. If you look at the branch in the main code viewer, you can see the badge in the README and see the top-level link that GitHub adds for the Code of Conduct at the top of the README viewer.
One other note: these files are both in the root of the repository, but I learned that you can alternatively add them to the
.github
directory. That's actually where the github docs repo has these files. On one hand, it keeps these types of files all in one place. On the other hand, they're a little less discoverable. Let me know if anyone has an opinion on the placement.