Upgrade ESLint and Prettier #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint is a major update which required a new configuration file format as well as using an 8.0.0 alpha version of @typescript-eslint. Also fixed all violations reported by updated ESLint and Prettier.
mint-thompson
previously approved these changes
Jul 22, 2024
jafeltra
approved these changes
Jul 23, 2024
mint-thompson
approved these changes
Jul 23, 2024
Yeah. I got that for free. For future reference, if you need to upgrade to ESLint 9, this is the easiest path: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Upgrade ESLint and Prettier to their latest versions. ESLint 9.x is a major update which requires a new configuration file format as well as using an 8.0.0 alpha version of @typescript-eslint. This upgrade resulted in new linting and prettier violations being reported, so this PR also fixes those new violations (several of which were real bugs).
Testing Instructions: Run
npm run checkto ensure that lint, prettier, and tests all pass.Related Issue: N/A