Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Shooter into Test Branch #3

Merged
merged 20 commits into from
Feb 24, 2024
Merged

Merge Shooter into Test Branch #3

merged 20 commits into from
Feb 24, 2024

Conversation

JosephMurdockCoding
Copy link
Contributor

Merging Shooter Subsystem
Can intake, pass notes between shooters, and shoot notes.

Copy link
Member

@shinthebinn shinthebinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to rename shooter to Shooter to match capitalization standards.

this.Shooter = shooter;
addCommands(
new StartShooter(shooter),
new PassNote(shooter),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will hang on pass note. Still putting through bc it's not bound anywhere

@shinthebinn shinthebinn merged commit 316b7dd into test Feb 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants