Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalised STORM environment implementation. #114

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

ali-shihab
Copy link
Contributor

Generalised STORM implementation developed at FLAIR. Key changes:

  1. Allows for any number of agents to be specified.
  2. Allows for any grid size to be specified (though this needs to be greater than the number of objects contained in the grid, obviously).
  3. Allows for any number of coins (per type) to be specified.

Some plots of: 1. mean proportion of red/defect coins held by agents in the environment; 2. mean returns; during IPPO test runs are provided (population sizes of 256, 512, 1024). Note that in all cases, the (defection) ratio converges to approx 0.8, which is expected behaviour for IPPO.

1024_agent_returns
1024_agent_coin_ratio
512_agent_returns
512_agent_coin_ratio
256_agent_returns
256_agent_coin_ratio

@Aidandos
Copy link
Contributor

Aidandos commented Sep 4, 2024

can you also add a tutorial like this https://github.com/FLAIROx/JaxMARL/blob/main/jaxmarl/tutorials/storm_2p_introduction.py ?

@ali-shihab
Copy link
Contributor Author

can you also add a tutorial like this https://github.com/FLAIROx/JaxMARL/blob/main/jaxmarl/tutorials/storm_2p_introduction.py ?

All done

@Aidandos
Copy link
Contributor

Aidandos commented Sep 5, 2024

Something seemed to have broken the tests with "InTheMatrix". Can you check what it is?

…ent in make(). minor adjustments to test script.
@ali-shihab
Copy link
Contributor Author

Apologies - I forgot to update the imports & some parts of registration.py, hence the InTheMatrix import wasn't working. Should work now.

Copy link
Contributor

@Aidandos Aidandos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Aidandos
Copy link
Contributor

Aidandos commented Sep 6, 2024

Can you also add a gif to JaxMarl/docs/imgs?

@amacrutherford
Copy link
Collaborator

great stuff :)

@amacrutherford amacrutherford merged commit 16a8f27 into FLAIROx:main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants