-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransfQMix release #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks cool! couple of minor points, also would be interesting to see the SMAX results
jaxmarl/wrappers/baselines.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove this no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes true, will do
jaxmarl/wrappers/transformers.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will each env need an if clause in __init__
? maybe worth putting a note if so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes every env that wants to use trasformers will need to wrap the environment observations in some way to be readable by the transformer. I could also reorganize it to have per-env specific wrappers if that would look better. I had put a note on the readme but now I see I deleted by mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just import from flax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the multihead attention from the fastattention script is significantly faster and more stable than the default flax one, which is beneficial in RL.
The script was taken in https://github.com/google-research/google-research/blob/master/performer/fast_attention/jax/fast_attention.py
Notice that the use of fast attention is optional:
baselines/QLearning/transf_qmix.py
Outdated
return train | ||
|
||
|
||
def signle_run(config): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 🙃 thanks
Here are the results average across 4 seeds:
Results are better than QMix for most of the maps with except of 3s5z and 3s5z_vs_3s_6z. But the main advantage of transformers is the potential transferability of the agent parameters and the learned qmix function between scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we removing the hanabi option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a preliminary way to create a global state vector for Hanabi. I realized that including the players' hands wasn't adding any new information, since those hands are already represented within the concatenated agent observations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cools !
awesome! |
No description provided.