Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non root Docker, Unpin Jax req, small IPPO qual of life improvements, MaBrax ReadMe note #97

Merged
merged 20 commits into from
Jun 13, 2024
Merged

Non root Docker, Unpin Jax req, small IPPO qual of life improvements, MaBrax ReadMe note #97

merged 20 commits into from
Jun 13, 2024

Conversation

amacrutherford
Copy link
Collaborator

No description provided.

@amacrutherford amacrutherford requested a review from mttga June 11, 2024 15:06
@amacrutherford amacrutherford mentioned this pull request Jun 11, 2024
Closed
@amacrutherford
Copy link
Collaborator Author

amacrutherford commented Jun 11, 2024 •
edited
Loading

have unpined JAX to greater than 0.4.16 and less than 0.4.26 so that the docker container does not reinstall jax

mttga
mttga approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@mttga mttga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think bounding jax to 4.25 is a good idea

@amacrutherford amacrutherford merged commit 45ff2fb into main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttga mttga mttga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amacrutherford @mttga