Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging models chapter #99

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Debugging models chapter #99

merged 1 commit into from
Oct 13, 2022

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Aug 1, 2022 •
edited
Loading

todo

  • Update Seatbelts
  • Draft printf
  • Draft logging
  • Draft debuggers
    • Windows x C++
    • Linux x C++
    • Windows x Python
    • Linux x Python
  • Add related links to each new page
  • Test and fix any syntax issues
  • Add a note that pure-python debugging isn't viable as debugger can't map back from C++ to Pyscript

Closes #93

@Robadob Robadob added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 1, 2022
@Robadob Robadob self-assigned this Aug 1, 2022
@Robadob Robadob changed the title WIP: Debugging models chapter Debugging models chapter Aug 1, 2022
@Robadob Robadob force-pushed the debugging_models branch 3 times, most recently from 8113fa8 to c397e00 Compare August 10, 2022 08:18
@Robadob
Copy link
Member Author

Robadob commented Aug 12, 2022

A little stumped with Windows x Python debugging, may have to leave that until I'm back in Shef and can try with the next-gen debugger.

@Robadob Robadob force-pushed the debugging_models branch 2 times, most recently from 0e24066 to 3856877 Compare August 31, 2022 15:54
@Robadob Robadob requested a review from ptheywood August 31, 2022 15:54
@Robadob Robadob marked this pull request as ready for review August 31, 2022 15:54
ptheywood
ptheywood requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, left a bunch of comments but its not far off at all.

nsight vscode can be added in the future / promoted to an issue (I'm happy to do this at some point if / when I find some time).

src/guide/debugging-models/index.rst Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/guide/debugging-models/index.rst Show resolved Hide resolved
src/guide/debugging-models/printf.rst Outdated Show resolved Hide resolved
src/guide/debugging-models/printf.rst Outdated Show resolved Hide resolved
src/guide/debugging-models/using-a-debugger.rst Outdated Show resolved Hide resolved
src/guide/debugging-models/logging.rst Outdated Show resolved Hide resolved
src/guide/debugging-models/logging.rst Outdated Show resolved Hide resolved
src/guide/debugging-models/logging.rst Outdated Show resolved Hide resolved
src/guide/debugging-models/logging.rst Show resolved Hide resolved
@ptheywood ptheywood mentioned this pull request Oct 13, 2022
Open
@Robadob
Debugging models chapter
57f5531 
SEATBELTS page has been moved here
Also corrected an issue in recent CMake changes where files containing special chars in their name were nolonger supported.
In testing, I was unable to find a way to breakpoint into RTC agent functions on Windows.
@Robadob Robadob merged commit ffadcf8 into master Oct 13, 2022
@Robadob Robadob deleted the debugging_models branch October 13, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptheywood ptheywood ptheywood approved these changes

Assignees

@Robadob Robadob

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model Debugging/Validation/Etc
2 participants
@Robadob @ptheywood