Skip to content

Commit

Permalink
CI: Add FLAMEGPU_SEATBELTS=OFF CI to the ubuntu and windows regular w…
Browse files Browse the repository at this point in the history
…orkflows

Using a number of exclude statemements, per OS the CI matrix should be:

+ 3 release console builds
+ 2 release vis builds
+ 1 beltsoff build

The matrix YAML is not techincally supported by Github actions according to the web editor
We should probably find a compliant way to do this, but it works so a problem for the future.

The individual example uses the same (relevant) options as the main configuration.
  • Loading branch information
ptheywood committed Nov 1, 2023
1 parent cd960c2 commit bd12412
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 6 deletions.
23 changes: 20 additions & 3 deletions .github/workflows/Ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,30 @@ jobs:
- name: "Release"
config: "Release"
SEATBELTS: "ON"
- name: "Beltsoff"
config: "Release"
SEATBELTS: "OFF"
VISUALISATION:
- "ON"
- "OFF"

exclude:
# Exclude VIS=ON for old cuda's.
# Exclude VIS=ON for oldest cuda.
- cudacxx:
cuda: "11.0"
VISUALISATION: "ON"
# Exclude beltsoff builds for old cuda's
- cudacxx:
cuda: "11.8"
config:
name: "Beltsoff"
- cudacxx:
cuda: "11.0"
config:
name: "Beltsoff"
# Exclude beltsoff vis builds to keep the matrix lighter.
- config:
name: "Beltsoff"
VISUALISATION: "ON"

# Name the job based on matrix/env options
name: "build (${{ matrix.cudacxx.cuda }}, ${{matrix.python}}, ${{ matrix.VISUALISATION }}, ${{ matrix.config.name }}, ${{ matrix.cudacxx.os }})"
Expand Down Expand Up @@ -164,6 +179,7 @@ jobs:
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DFLAMEGPU_BUILD_TESTS="${{ env.FLAMEGPU_BUILD_TESTS }}"
-DFLAMEGPU_BUILD_PYTHON="${{ env.FLAMEGPU_BUILD_PYTHON }}"
-DPYTHON3_EXACT_VERSION="${{ env.PYTHON }}"
Expand Down Expand Up @@ -197,9 +213,10 @@ jobs:
-Werror=dev
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_VISUALISATION="${{ env.VISUALISATION }}"
-DFLAMEGPU_ENABLE_NVTX="ON"
-DFLAMEGPU_SEATBELTS="OFF"
- name: Build Individual example
if: ${{ env.INDIVIDUAL_EXAMPLE != '' }}
Expand Down
23 changes: 20 additions & 3 deletions .github/workflows/Windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,30 @@ jobs:
- name: "Release"
config: "Release"
SEATBELTS: "ON"
- name: "Beltsoff"
config: "Release"
SEATBELTS: "OFF"
VISUALISATION:
- "ON"
- "OFF"

exclude:
# Exclude VIS=ON for old cuda's.
# Exclude VIS=ON for oldest cuda.
- cudacxx:
cuda: "11.0.3"
VISUALISATION: "ON"
# Exclude beltsoff builds for old cuda's
- cudacxx:
cuda: "11.8.0"
config:
name: "Beltsoff"
- cudacxx:
cuda: "11.0.3"
config:
name: "Beltsoff"
# Exclude beltsoff vis builds to keep the matrix lighter.
- config:
name: "Beltsoff"
VISUALISATION: "ON"

# Name the job based on matrix/env options
name: "build (${{ matrix.cudacxx.cuda }}, ${{matrix.python}}, ${{ matrix.VISUALISATION }}, ${{ matrix.config.name }}, ${{ matrix.cudacxx.os }})"
Expand Down Expand Up @@ -121,6 +136,7 @@ jobs:
-Werror=dev
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_BUILD_TESTS="${{ env.FLAMEGPU_BUILD_TESTS }}"
-DFLAMEGPU_BUILD_PYTHON="${{ env.FLAMEGPU_BUILD_PYTHON }}"
Expand Down Expand Up @@ -167,9 +183,10 @@ jobs:
-Werror=dev
-DCMAKE_WARN_DEPRECATED="OFF"
-DFLAMEGPU_WARNINGS_AS_ERRORS="ON"
-DFLAMEGPU_SEATBELTS="${{ env.FLAMEGPU_SEATBELTS }}"
-DCMAKE_CUDA_ARCHITECTURES="${{ env.CUDA_ARCH }}"
-DFLAMEGPU_VISUALISATION="${{ env.VISUALISATION }}"
-DFLAMEGPU_ENABLE_NVTX="ON"
-DFLAMEGPU_SEATBELTS="OFF"
- name: Build Individual example
if: ${{ env.INDIVIDUAL_EXAMPLE != '' }}
Expand Down

0 comments on commit bd12412

Please sign in to comment.