Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples readme #1105

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Examples readme #1105

merged 2 commits into from
Sep 22, 2023

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Sep 14, 2023

Also noticed diffusion example wasn't using orthographic vis.

ptheywood
ptheywood previously approved these changes Sep 20, 2023
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text is great.

The images when set to 100% width look a bit blurry though, as the linked resources seem to be 480x360 px, so with the style="width:100% they get pretty blurry.

Could probably just do them as standard markdown embeds instead and not worry about the width etc?

i.e. instead of:

<div align="left">
    <a href="https://www.youtube.com/watch?v=eE646_6NfqQ">
        <img src="https://img.youtube.com/vi/eE646_6NfqQ/0.jpg" style="width:100%;">
    </a>
</div>
[![Boids screenshot](https://img.youtube.com/vi/eE646_6NfqQ/0.jpg)](https://www.youtube.com/watch?v=eE646_6NfqQ)

Boids screenshot

Unless there's a way to get a higher res youtube still?

This briefly summarises each model, and links to a video of the visualisation where available.

Closes #1104
@Robadob Robadob merged commit 71a0501 into master Sep 22, 2023
18 checks passed
@Robadob Robadob deleted the examples_readme branch September 22, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants