DeviceAPI::isAgent() DeviceAPI::isState() #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With new C/Python tests Closes #1108 Currently only RTC implemented with Python test.
Robadob
commented
Sep 26, 2023
| @@ -132,7 +132,7 @@ void CUDAAgent::setPopulationData(const AgentVector& population, const std::stri | |||
| if (state_name == ModelData::DEFAULT_STATE) { | |||
| THROW exception::InvalidAgentState("Agent '%s' does not use the default state, so the state must be passed explicitly, " | |||
| "in CUDAAgent::setPopulationData()", | |||
| state_name.c_str(), population.getAgentName().c_str()); | |||
There was a problem hiding this comment.
Had this exception thrown whilst writing test, noticed it was wrong.
mondus
reviewed
Sep 29, 2023
| * | ||
| * @note Implementation based on https://stackoverflow.com/a/34873763/1646387 | ||
| */ | ||
| __device__ __forceinline__ int dstrcmp(const char *s1, const char *s2) { |
There was a problem hiding this comment.
This will not be resolved at compile time for RTC due to the use of the while loop. If we really wanted to have this resolve at compile time we would have to find a way for this to work with constexpr or a through template recursion. I don't think this is necessary though and we should flag that string comparisons are not particularly fast in the docs.
mondus
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new C/Python tests
Closes #1108
Todo
Note
strcmp()is not defined in device code, so ripped a small correct looking implementation off stack overflow (found inutil/dstring.h).Branch should be squashed