Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes UserTransformer creates invalid address objects #769 (with tests) #778

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

bltravis
Copy link
Collaborator

Closes #769

@bltravis bltravis linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (cf94fa2) to head (c6419f2).

Files Patch % Lines
...igration_tools/migration_tasks/user_transformer.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   71.94%   72.00%   +0.06%     
==========================================
  Files         103      103              
  Lines       11409    11435      +26     
  Branches     1370     1377       +7     
==========================================
+ Hits         8208     8234      +26     
  Misses       2904     2904              
  Partials      297      297              
Flag Coverage Δ
unittests 72.00% <97.05%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@bltravis bltravis merged commit 7fcd1cc into main Jul 10, 2024
2 checks passed
@bltravis bltravis deleted the 769-usertransformer-creates-invalid-address-objects branch July 10, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserTransformer creates invalid address objects
1 participant