Skip to content

Fixes Pymarc 5.2.0 breaks MARC transformer tasks #783. #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

bltravis
Copy link
Collaborator

Updates MARC processing modules and associated tests/test data.

…rocessing modules and associated tests/test data.
@bltravis bltravis linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (1f9fb64) to head (9056e84).

Files Patch % Lines
...s/marc_rules_transformation/marc_reader_wrapper.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   72.00%   71.98%   -0.03%     
==========================================
  Files         104      104              
  Lines       11436    11426      -10     
  Branches     1378     1378              
==========================================
- Hits         8235     8225      -10     
  Misses       2904     2904              
  Partials      297      297              
Flag Coverage Δ
unittests 71.98% <96.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@bltravis bltravis requested a review from banerjek July 31, 2024 15:32
Copy link
Member

@banerjek banerjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, marcfix should already fixes the "4500" at the end and it would take 30 seconds to have it also address chars 10 and 11. Not sure if we care but just observing

@bltravis bltravis merged commit d198e84 into main Jul 31, 2024
3 of 4 checks passed
@bltravis bltravis deleted the 783-pymarc-520-breaks-marc-transformer-tasks branch July 31, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pymarc 5.2.0 breaks MARC transformer tasks
2 participants