713 empty renewal count causes loan not to be migrated #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses the issue where loan records with empty or missing
renewal_count
fields were not being migrated properly. Fixes #713. The solution ensures that missingrenewal_count
values are set to0
, preventing migration errors.Changes Made in this PR
renewal_count
fields in loan records.renewal_count
to0
if it is absent.renewal_count
values.Code Review Specifics
renewal_count
fields.Task Checklist
nox -rs safety
.pre-commit run --all-files
.nox -rs tests
.cd src; poetry run python3 -m folio_migration_tools -h
.Warning Checklist
How to Verify
renewal_count
values.renewal_count
set to0
.Open Questions
None at the moment.
Learn Anything Cool?
I learned about how
folio_migration_tools
handles optional fields likerenewal_count
during the migration process.