-
Notifications
You must be signed in to change notification settings - Fork 169
add event #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add event #486
Conversation
JustinBenito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @murugilax11
Thanks a lot for the contribution please do make the requested changes and ideally use podu.pics instead of adding a new hostname in next.config.
Also plrease revert back in the package.json file (We do it monthly or bimonthly from the maintainers side )
Thanks a lot.
Looking to merge as soon as possible once the changes are done.
Cheers :D
src/data/events.json
Outdated
| "eventTime": "09:30 - 01:00", | ||
| "eventVenue": "PSR Engineering College", | ||
| "eventLink": "https://techkoodaram.in", | ||
| "location": "Sivakasi, Tamil Nadu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just Sivakasi would be better to suit the UI.
It would be great if we had a screenshot to review before this.
src/data/events.json
Outdated
| "eventName": "techKoodaram #1", | ||
| "eventDescription": "techKoodaram #1 is the first in-person tech meetup focused on learning, discussions, and real-world tech insights. Participation is approval-based to keep the experience meaningful.", | ||
| "eventDate": "2026-01-24", | ||
| "eventTime": "09:30 - 01:00", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the start time should do, we don't include start and end time which will not look good on the UI side. Please fix this aswell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JustinBenito
Thanks for the review!
Updated event time to start time only .
Simplified location to "Sivakasi" .
Reverted package.json as requested.
No changes were made to next.config.js.
Changes have been pushed.
Please let me know if anything else is needed
📝 WalkthroughWalkthroughTwo straightforward additions: a new remote image pattern for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧹 Recent nitpick comments
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Comment |
add registration details
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.