Skip to content

Implement feature to temporarily disable NFC cards #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jappyjan wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Implement feature to temporarily disable NFC cards #52

jappyjan wants to merge 7 commits into from

Conversation

@jappyjan
Copy link
Collaborator

@jappyjan jappyjan commented May 22, 2025 •
edited
Loading

Closes #35

This PR implements the feature to allow users to temporarily disable their NFC cards when they lose them.

Changes:

  • Added isDisabled flag to the NFCCard entity with default value of false
  • Added endpoint to set the disabled status of a card (not toggle)
  • Updated the frontend to show the card status and allow enabling/disabling it
  • Added check in the reader state to prevent disabled cards from being used
  • Updated translation files with new strings for disabled status
  • Fixed card enrollment to include isDisabled field

@github-actions
Copy link

github-actions bot commented May 22, 2025

🐳 Docker images built and pushed:

GitHub Container Registry: ghcr.io/fabinfra/attraccess:pr-52-10e4632
Docker Hub: fabaccess/attraccess:pr-52-10e4632

Image Digest: sha256:c0a012b79c6d903bd2e8b177ce5c1ebb39241456948762522157067b905b02a7

@openhands-agent
Merge main into feature/disable-nfc-cards
af4edfb 
Resolved conflicts in libs/api-client/src/generated/Api.ts by:
- Keeping the new SetNfcCardDisabledDto and SetNfcCardDisabledResponseDto interfaces
- Adding isDisabled field to NFCCard interface
- Preserving SetCardDisabledData type and setCardDisabled API method
- Integrating with resource documentation changes from main branch
@github-actions
Copy link

github-actions bot commented May 24, 2025

🐳 Docker images built and pushed:

GitHub Container Registry: ghcr.io/fabinfra/attraccess:pr-52-f6a1aa8
Docker Hub: fabaccess/attraccess:pr-52-f6a1aa8

Image Digest: sha256:84239de83bfe429c1c021670913cdef1737002365e71455e46a78c318c32d27f

@openhands-agent
Fix failing test: add isDisabled field to createNFCCard expectation
a2d4f9a 
- Updated enroll-ntag424.state.spec.ts to expect isDisabled: false field
- This aligns with the new isDisabled feature implementation
@github-actions
Copy link

github-actions bot commented May 25, 2025

🐳 Docker images built and pushed:

GitHub Container Registry: ghcr.io/fabinfra/attraccess:pr-52-cc531a8
Docker Hub: fabaccess/attraccess:pr-52-cc531a8

Image Digest: sha256:af53808a3e2f99aa6aee625a688d687e5f9f2873d4d03d61939172da94c7e71c

@github-actions
Copy link

github-actions bot commented May 28, 2025

🐳 Docker images built and pushed:

GitHub Container Registry: ghcr.io/fabinfra/attraccess:pr-52-87f8e56
Docker Hub: fabaccess/attraccess:pr-52-87f8e56

Image Digest: sha256:fe1568e9b5552f05c89ec5c13c4e023812a41c8e5fed00814d6e832398185862

@github-actions
Copy link

github-actions bot commented May 30, 2025

🐳 Docker images built and pushed:

GitHub Container Registry: ghcr.io/fabinfra/attraccess:pr-52-621e36b
Docker Hub: fabaccess/attraccess:pr-52-621e36b

Image Digest: sha256:46fa531c5118637ab5aef58f71f16ab993a3681637f8c35eec269ab19627eece

@jappyjan jappyjan added the needs-refinement The issue does not contain enough information or needs to be further discussed label Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-refinement The issue does not contain enough information or needs to be further discussed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fabreader allow users to temporarily disable nfc cards

3 participants

@jappyjan @openhands-agent