Improve performance of get_relative_path #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs extensive testing.... One more thing. @Axenide, excuse me, but what the actual fuck? |
|
🤔 |
|
While testing I noticed a significant improvement (almost 20x). Took only 0.1s for 100k calls compared to the current implementations 2s. |
|
Okay, that's it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspect.stack() is extremely slow. Using _getframe on cpython is way faster. Wasn't able to test pypy's _getframe but can't imagine it being slower than getting the entire stack.
This change lowered real life CPU usage in ax-shell in idle from about 3% to 1.5% on my system. Could avoid using this function in ax-shell but fabric itself uses it in many places so fixing it upstream would be perfect.
Used Austin to find the bottleneck if someone wants to confirm the issue.