Update ParticleRendererRegistry test to use a fully custom Particle#4885
Draft
Grauly wants to merge 3 commits intoFabricMC:1.21.9from
Draft
Update ParticleRendererRegistry test to use a fully custom Particle#4885Grauly wants to merge 3 commits intoFabricMC:1.21.9from
Grauly wants to merge 3 commits intoFabricMC:1.21.9from
Conversation
Member
|
The mixin fix was cherry-picked in: ed8c182 as its quite clearly wrong, and the fix is needed as a priority. The test changes need more work/input from someone who can help. They can be merged at a later date. |
Previous implementation of the tests did not require the API to actually be functional, as long as the particle was a BillboardParticle
Grauly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally this PR included a mixin fix which was cherry-picked below.
It changes the ParticleRendererRegistryTest to use a non
BillboardParticleParticle, to test fully custom particles.This PR is not entirely ready to merge, there are a few issues left to be solved:
SpriteAtlasTexture.BLOCK_ATLAS_TEXTURETestParticlePositionswould require alot more buffer work in there.