Various Sitewide Fixes & Improvements. #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMB11
added
improvement
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…equired.) and document more.
its-miroma
requested changes
Jan 17, 2025
Comment on lines
+59
to
+93
| // Constructs the appropriate route path for a given version | ||
| function buildRoutePath( | ||
| currentPath: string, | ||
| locale: string | null, | ||
| version: string, | ||
| isOnLatest: boolean | ||
| ) { | ||
| if (locale) { | ||
| // Replace or add version segment while keeping the locale | ||
| // e.g. /en/ -> /en/1.2.0/ or /en/1.2.0/ -> /en/1.3.0/ | ||
| if (!isOnLatest) { | ||
| if (version === props.versioningPlugin.latestVersion) { | ||
| route = router.route.path.replace( | ||
| `/${locale}/${currentVersion.value}/`, | ||
| `/${locale}/` | ||
| ); | ||
| return currentPath.replace(`/${locale}/${currentVersion.value}/`, `/${locale}/`); | ||
| } else { | ||
| route = router.route.path.replace( | ||
| `/${locale}/${currentVersion}/`, | ||
| `/${locale}/${version}/` | ||
| ); | ||
| // Replace any existing version segment with the new one | ||
| return currentPath.replace(`/${locale}/${currentVersion.value}/`, `/${locale}/${version}/`); | ||
| } | ||
| } else { | ||
| route = router.route.path.replace( | ||
| `/${locale}/`, | ||
| `/${locale}/${version}/` | ||
| ); | ||
| // If currently on latest, just add the new version segment | ||
| return currentPath.replace(`/${locale}/`, `/${locale}/${version}/`); | ||
| } | ||
| } else { | ||
| // Non-localized routes | ||
| // e.g. / -> /1.2.0/ or /1.2.0/ -> /1.3.0/ | ||
| if (!isOnLatest) { | ||
| if (version === props.versioningPlugin.latestVersion) { | ||
| route = router.route.path.replace(`/${currentVersion.value}/`, "/"); | ||
| return currentPath.replace(`/${currentVersion.value}/`, "/"); | ||
| } else { | ||
| route = router.route.path.replace( | ||
| `/${currentVersion.value}/`, | ||
| `/${version}/` | ||
| ); | ||
| return currentPath.replace(`/${currentVersion.value}/`, `/${version}/`); | ||
| } | ||
| } else { | ||
| route = router.route.path.replace("/", `/${version}/`); | ||
| return currentPath.replace("/", `/${version}/`); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
i think this could simply be something like:
currentPath.replace(
currentVersion.value === props.versioningPlugin.latestVersion
? "/"
: `/${currentVersion.value}/`,
newVersion.value === props.versioningPlugin.latestVersion
? "/"
: `/${newVersion.value}/`
);There was a problem hiding this comment.
Yours doesn't handle locales
There was a problem hiding this comment.
How so? If you've got /it_it/1.20.4/link/to/page, and you replace /1.20.4/ with /1.21/, you end up with /it_it/1.21/link/to/page, which is correct
There was a problem hiding this comment.
Just tried it, it doesn't work when switching between versions whilst a locale is present. What we have works, I dont think it needs to be changed for the sake of changing it.
There was a problem hiding this comment.
I'd forgotten the dollar signs; you may keep it as is if it is not worth changing tho
modmuss50
reviewed
Jan 17, 2025
its-miroma
requested changes
Jan 17, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
its-miroma
previously approved these changes
Jan 18, 2025
Merged
modmuss50
previously approved these changes
Jan 22, 2025
modmuss50
approved these changes
Jan 22, 2025
its-miroma
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239