Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling RunConfig appending project path #1005

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

MattSturgeon
Copy link
Contributor

I'd like to have more control over run config names in sub-projects, for example something like:

allprojects {
  loom {
    runs {
      client {
        configName "Run ${project.path.replaceAll ':', ' '}"
        appendProjectPathToConfigName false
      }
      remove server
    }
  }
}

This PR adds that capability.

All tests passed when running :check locally.

I'd like to have introduced a test for both the default & modified behavior, however I'm a bit lost in your test suite and didn't want to spend much time on this PR without knowing how it'd be received.

If someone more knowledgeable would like to write a test or guide me through the process that'd be appreciated.

modmuss50 and others added 2 commits December 9, 2023 22:27
Add a `appendConfigNameWithPath` property to `RunConfigSettings` controlling whether to append the path for non-root projects.

Default behaviour is unchanged.
@MattSturgeon MattSturgeon force-pushed the configure-config-namer branch from 5994c80 to 509266c Compare December 16, 2023 14:49
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, its not great but the only way to do it without breaking.

RunConfigSettings is something I'd like to make breaking changes to anyway if/when we do a loom 2.0.

@modmuss50 modmuss50 changed the base branch from dev/1.4 to exp/1.5 December 19, 2023 13:48
@modmuss50 modmuss50 merged commit bbf7f96 into FabricMC:exp/1.5 Dec 19, 2023
75 of 76 checks passed
@modmuss50 modmuss50 added this to the 1.5 milestone Dec 19, 2023
@MattSturgeon MattSturgeon deleted the configure-config-namer branch December 19, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants