Merged
Conversation
deirn
reviewed
Feb 15, 2026
src/workers/JarIndex.ts
Outdated
Comment on lines
130
to
134
| promises.push(new Promise(async (resolve) => { | ||
| while (true) { | ||
| const batch = taskQueue.splice(0, batchSize); | ||
| promises.push(new Promise((resolve) => { | ||
| const processQueue = async () => { | ||
| while (true) { | ||
| const batch = taskQueue.splice(0, batchSize); |
Member
There was a problem hiding this comment.
This one is weird. Will the function not get awaited then?
Member
Author
There was a problem hiding this comment.
I'll take a closer look, it wasn't happy about having an async function passed to the Promise constructor.
Member
Author
There was a problem hiding this comment.
This change here was correct and maintained the same behaviour as before, the processQueue function would not get awaited, but the promise stored in promises would complete correctly when resolve is called. I have refactored this to just have an inline async lambda, removing the need to use new Promise and call resolve.
deirn
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.