Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename confusing names and add some javadoc in n.m.server.world #3635

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Rename confusing names and add some javadoc in n.m.server.world #3635

merged 1 commit into from
Aug 17, 2023

Conversation

lovexyn0827
Copy link
Contributor

Fixes: #3628 and #3545

@modmuss50
Copy link
Member

Did you mean to make this PR for 23w14a? If not we can get the bot to update it to 23w32a.

@lovexyn0827
Copy link
Contributor Author

Did you mean to make this PR for 23w14a? If not we can get the bot to update it to 23w32a.

No, updating it to 23w32a will be fine.
It is only because the default branch of my fork is 23w14a and i forgot to fetch recent changes.

@modmuss50 modmuss50 added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Aug 16, 2023
@github-actions github-actions bot changed the base branch from 23w14a to 23w32a August 16, 2023 23:14
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 23w32a

@github-actions
Copy link
Contributor

🚨 Unable to automatically update branch with the latest changes

@github-actions github-actions bot added snapshot A PR that targets a snapshot version of Minecraft and removed update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Aug 16, 2023
apple502j
apple502j reviewed Aug 17, 2023
View reviewed changes
mappings/net/minecraft/server/world/ThreadedAnvilChunkStorage.mapping Outdated
@@ -56,6 +56,8 @@ CLASS net/minecraft/class_3898 net/minecraft/server/world/ThreadedAnvilChunkStor
METHOD method_17216 getChunkHolder (J)Lnet/minecraft/class_3193;
ARG 1 pos
METHOD method_17217 setLevel (JILnet/minecraft/class_3193;I)Lnet/minecraft/class_3193;
COMMENT Sets the loading level of {@code ChunkHolders}. Nonexistent {@code ChunkHolder}s will be created automaiccally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry for this mistake

@modmuss50 modmuss50 merged commit ac5a18c into FabricMC:23w32a Aug 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apple502j apple502j apple502j left review comments

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename ChunkTicketManager.chunkHolders to make its usage more clear
3 participants
@lovexyn0827 @modmuss50 @apple502j