Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Sherds#stream() to Sherds#toList() #3976

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

axialeaa
Copy link
Contributor

@axialeaa axialeaa commented Sep 4, 2024

Sherds#stream() has a return value of List<Item>, which means if someone wanted to convert the list to a stream of type Item, they would have to write sherds.stream().stream() which is confusing and counterintuitive.

This pull request just changes stream() to toList(), making it very obvious what it's doing.

@haykam821 haykam821 added the bug Fixes or discusses a bug within the mappings label Sep 4, 2024
@Shnupbups Shnupbups merged commit b5def06 into FabricMC:24w35a Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants