Fix initial remove #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@LinkedFluuuush Sorry, for closing all of your PRs, that was not my intention. Also thank you for all of the work you put into this addon. All of them look quite useful from quickly glancing at them. I will take a closer look before merging them, but this might take a bit, as I am currently a little bit busy with other stuff. So please bear with me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this got deleted due to a branch name change, so I reopen it :)
Feel free to close again if you don't want this change :)
This fixes issue #19 by deleting existing pins only when the persistent pin list is empty, i.e. when the module is first installed.