Skip to content

DO-NOT-MERGE: Enable more clang-tidy warnings. #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

DO-NOT-MERGE: Enable more clang-tidy warnings. #1365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27c243
clang-tidy: Add cppcoreguidelines-pro-type-member-init
ChristianTackeGSI Nov 16, 2022
ac95a31
DO-NOT-MERGE: Only important builds
ChristianTackeGSI Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ HeaderFilterRegex: '.*'
# Avoid undefined behaviour
# * cppcoreguidelines-pro-type-cstyle-cast
# Avoid C-Style Casts which might be problematic
# * cppcoreguidelines-pro-type-member-init
# Avoid unitialized member variables
# enable google-build-using-namespace
# "using namespace" imports a changing amount of symbols, avoid it
# improve readability:
Expand All @@ -22,6 +24,7 @@ Checks: >-
-bugprone-unhandled-self-assignment,
-bugprone-reserved-identifier,
cppcoreguidelines-pro-type-cstyle-cast,
cppcoreguidelines-pro-type-member-init,
cppcoreguidelines-virtual-class-destructor,
modernize-make-unique,
google-build-using-namespace,
Expand Down
25 changes: 0 additions & 25 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,14 @@
#!groovy

def macos_builds = [
[os: "macos", ver: "13", arch: "x86_64", compiler: "apple-clang-14", fairsoft: "24.01"],
[os: "macos", ver: "14", arch: "x86_64", compiler: "apple-clang-14", fairsoft: "24.01"],
[os: "macos", ver: "14", arch: "arm64", compiler: "apple-clang-15", fairsoft: "24.01"],
]

def linux_builds = [
[os: "debian", ver: "10", compiler: "gcc-8", fairsoft: "jan24_patches", image: "jan24"],
[os: "debian", ver: "10", compiler: "gcc-8", fairsoft: "jan24_patches_mt", image: "jan24"],
[os: "debian", ver: "10", compiler: "gcc-8", fairsoft: "nov22_patches", image: "nov22"],
[os: "debian", ver: "10", compiler: "gcc-8", fairsoft: "apr22_patches", image: "apr22"],
[os: "debian", ver: "11", compiler: "gcc-10", fairsoft: "jan24_patches", image: "jan24"],
[os: "debian", ver: "11", compiler: "gcc-10", fairsoft: "jan24_patches_mt", image: "jan24"],
[os: "debian", ver: "11", compiler: "gcc-10", fairsoft: "nov22_patches", image: "nov22"],
[os: "debian", ver: "11", compiler: "gcc-10", fairsoft: "apr22_patches", image: "apr22"],
[os: "debian", ver: "12", compiler: "gcc-12", fairsoft: "jan24_patches", image: "jan24"],
[os: "debian", ver: "12", compiler: "gcc-12", fairsoft: "jan24_patches_mt", image: "jan24"],
[os: "debian", ver: "12", compiler: "gcc-12", fairsoft: "nov22_patches", image: "nov22"],
[os: "fedora", ver: "39", compiler: "gcc-13", fairsoft: "jan24_patches", image: "jan24"],
[os: "fedora", ver: "39", compiler: "gcc-13", fairsoft: "jan24_patches_mt", image: "jan24"],
[os: "ubuntu", ver: "20.04", compiler: "gcc-9", fairsoft: "jan24_patches", image: "jan24"],
[os: "ubuntu", ver: "20.04", compiler: "gcc-9", fairsoft: "jan24_patches_mt", image: "jan24"],
[os: "ubuntu", ver: "20.04", compiler: "gcc-9", fairsoft: "nov22_patches", image: "nov22"],
[os: "ubuntu", ver: "20.04", compiler: "gcc-9", fairsoft: "apr22_patches", image: "apr22"],
[os: "ubuntu", ver: "22.04", compiler: "gcc-11", fairsoft: "jan24_patches", image: "jan24"],
[os: "ubuntu", ver: "22.04", compiler: "gcc-11", fairsoft: "jan24_patches_mt", image: "jan24"],
[os: "ubuntu", ver: "22.04", compiler: "gcc-11", fairsoft: "nov22_patches", image: "nov22"],
[os: "ubuntu", ver: "22.04", compiler: "gcc-11", fairsoft: "apr22_patches", image: "apr22"],
[os: "ubuntu", ver: "rolling", compiler: "current", fairsoft: "dev", check: "warnings",
extra: "-DUSE_CLANG_TIDY=ON -DBUILD_MBS=OFF -DBUILD_PROOF_SUPPORT=OFF"],
]

def linux_checks = [
[os: 'ubuntu', ver: 'rolling', compiler: 'current', fairsoft: 'dev', check: 'doxygen'],
]

def isBranchBuild() {
Expand Down