Merge pull request #61 from ddunkin/node-bin

Don't delete `node_modules/**/bin` when cleaning
Faithlife · May 9, 2024 · 35e50c4 · 35e50c4
2 parents ecb9941 + a92be29
commit 35e50c4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,7 +1,7 @@
 <Project>
 
   <PropertyGroup>
-    <VersionPrefix>5.20.0</VersionPrefix>
+    <VersionPrefix>5.20.1</VersionPrefix>
     <PackageValidationBaselineVersion>5.19.1</PackageValidationBaselineVersion>
     <LangVersion>12.0</LangVersion>
     <Nullable>enable</Nullable>

diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -1,5 +1,9 @@
 # Release Notes
 
+## 5.20.1
+
+* Don't delete `node_modules/**/bin` when cleaning.
+
 ## 5.20.0
 
 * Add `Version` to `DotNetLocalTool`.

diff --git a/src/Faithlife.Build/DotNetBuild.cs b/src/Faithlife.Build/DotNetBuild.cs
@@ -56,7 +56,7 @@ public static void AddDotNetTargets(this BuildApp build, DotNetBuildSettings? se
 			.Does(() =>
 			{
 				var findDirectoriesToDelete = settings.CleanSettings?.FindDirectoriesToDelete ??
-					(() => FindDirectories("{src,tests,tools}/**/{bin,obj}").Except(FindDirectories("tools/bin")).ToList());
+					(() => FindDirectories("{src,tests,tools}/**/{bin,obj}").Except(FindDirectories("tools/bin", "**/node_modules/**/bin")).ToList());
 				foreach (var directoryToDelete in findDirectoriesToDelete())
 					DeleteDirectory(directoryToDelete);