-
Notifications
You must be signed in to change notification settings - Fork 6
Add support for optional "embedded" extension for embedded FalkorDB #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
|
@copilot the code should not depend on redislite but should copy the functionality to this project. |
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Done! I've replaced the dependency on Changes:
The embedded functionality is now fully integrated into this project with clear error messages to guide users on setup. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 91.69% 82.63% -9.06%
==========================================
Files 36 19 -17
Lines 2685 1319 -1366
==========================================
- Hits 2462 1090 -1372
- Misses 223 229 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot please fix the codecov and spellcheck errors |
|
@copilot the download and build of Redis and FalkorDB shouldn't be done manually by the developer. |
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Fixed in commit 8101398. Changes:
The spellcheck and codecov checks should now pass. |
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Done in commit 44ac979! Following the falkordblite setup pattern: Changes:
Installation: FALKORDB_BUILD_EMBEDDED=1 pip install falkordb[embedded]The user no longer needs to manually install redis-server or download the FalkorDB module - everything is automated during the pip install process, just like in falkordblite. |
|
@copilot why does it require according to the README to set the FALKORDB_BUILD_EMBEDDED=1? |
|
@copilot please fix the spell check and codecov errors |
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Fixed in commit 98f3693! The pip install falkordb[embedded]The setup.py now automatically builds embedded binaries when building from source. Users who want faster installation without embedded support can opt-out with |
…up.py Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Fixed in commit be9f250. Changes:
The spellcheck and codecov checks should now pass. |
All checks should now pass:
Original prompt
Fixes #129
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.