-
Notifications
You must be signed in to change notification settings - Fork 1
Add support for embedded FalkorDB server #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Added EmbeddedConfig and EmbeddedServer types - Added Embedded variant to FalkorConnectionInfo - Updated client builder to start embedded server - Added embedded feature flag with which dependency - Embedded server spawns redis-server with FalkorDB module via Unix socket Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
- Added embedded_usage.rs example showing how to use embedded feature - Added tests for embedded configuration and error handling - Updated README.md with embedded feature documentation - Fixed connection_info tests to handle Embedded variant Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Move crate imports after std imports following Rust conventions Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 85.83% 85.17% -0.67%
==========================================
Files 28 28
Lines 3940 3656 -284
Branches 3940 3656 -284
==========================================
- Hits 3382 3114 -268
- Misses 386 390 +4
+ Partials 172 152 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot please see the failed checks |
Add embedded-related terms to .github/wordlist.txt to fix spellcheck CI Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
I've reviewed the failed checks and identified the issue. The spellcheck workflow was failing because new terms introduced in the documentation weren't in the wordlist. I've added the following words to
Fixed in commit |
Plan for adding embedded FalkorDB support:
Implementation complete and ready for review:
embeddedmodule withEmbeddedServerandEmbeddedConfigThe feature is ready for use with the
embeddedfeature flag.Example usage:
Original prompt
Fixes #134
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.