修复与最新版minihud不兼容 #82
Merged
修复与最新版minihud不兼容 #82
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请阐述新增/修改代码的实现依据，包括但不限于：
而非直接无依无据地提供一份代码并请求合并 除此之外，形如“malilib需自行将模组放入mods文件”的依赖应用方式是不可接受的，这会让此项目的环境初始化不再有稳定的可复现性。请正确地使用 maven 声明依赖。若不确定该如何引用非 curseforge 的依赖，可以直接提出 |
|
赞👍 |
|
修改完成, 现malilib与minihud均来自jitpack |
|
如果仅仅是改了个 |
...breath/tweakermore/mixins/tweaks/mod_tweaks/serverDataSyncer/minihud/RenderHandlerMixin.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #79
造成兼容问题原因
minihud更改了原
this.getTargetedBlockEntity()的返回类型, 现在它不再返回BlockEntity， 而是返回Pair<BlockEntity, NbtCompound>包装, 因此mixin注入失败引发崩溃修复
调整注入目标的返回值更改为正确的
Lcom/llamalad7/mixinextras/lib/apache/commons/tuple/Pair;即可, 使用getLeft()方法即可从中获取BlockEntity同步蜜蜂数量可以正常工作
另: curseforge上相关mod未更新, 因此使用来自jitpack的构建(malilib, minihud).
(modrinth上相关mod已更新, 或许可以使用modrinth maven替换curse maven?)