Skip to content

IIIF V3 Working Version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jason-Benson wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

IIIF V3 Working Version #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
435c82f
IIIF V3 Working Version
Jason-Benson Oct 21, 2025
3e9bd1b
IIIF V3 Working Version
Jason-Benson Oct 22, 2025
7439eb5
Merge remote-tracking branch 'upstream/dev' into iiifV3
Jason-Benson Oct 22, 2025
ad0f3d9
IIIF V3 Ammended
Jason-Benson Oct 23, 2025
5955b41
additional polish for IIIF 3 Manifest Generator.
Jason-Benson Oct 27, 2025
aa52d52
Fixed perms!
Jason-Benson Oct 27, 2025
19504d3
Additional polish on IIIF 3.0 manifest generator
Jason-Benson Nov 3, 2025
3d2e4de
fixed bug in manifest generator that prevented metadata from being re…
Jason-Benson Nov 3, 2025
0c2e5bf
forgot to remove an uneeded comment
Jason-Benson Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions module/DigLib/src/DigLib/Controller/VuDLController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,16 +846,16 @@ public function passthroughAction()
protected function getIdsFromManifest($data)
{
$ids = [];
if (isset($data['sequences'][0]['canvases'])) {
foreach ($data['sequences'][0]['canvases'] as $canvas) {
preg_match(
'/vudl:[0-9]+/',
$canvas['rendering'][0]['@id'] ?? '',
$matches
);
if (isset($matches[0])) {
$ids[] = $matches[0];
}

foreach ($data['items'] as $canvas) {
Copy link
Contributor

@demiankatz demiankatz Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding this little safety check so if 'items' is somehow undefined, the system doesn't error out.

Suggested change
foreach ($data['items'] as $canvas) {
foreach ($data['items'] ?? [] as $canvas) {

preg_match(
'/vudl:[0-9]+/',
$canvas['rendering'][0]['id'] ?? '',
$matches
);

if (isset($matches[0])) {
$ids[] = $matches[0];
}
}
return $ids;
Expand Down
Loading