Fix error default page not loaded #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add warning log when refreshing UI without current page.
|
|
||
| UUIDComponent uuidComponent = store.getComponent(ref, UUIDComponent.getComponentType()); | ||
| FancyPlayerImpl fp = (FancyPlayerImpl) getPlayerService().getByUUID(uuidComponent.getUuid()); | ||
| UUIDComponent uuidComponent = ref.getStore().getComponent(ref, UUIDComponent.getComponentType()); |
Member
There was a problem hiding this comment.
Why don't you use the store var that you added above?
OliverSchlueter
requested changes
Jan 27, 2026
| private void load() { | ||
| List<ScoreboardPage> pages = storage.loadAllPages(); | ||
| if (pages == null || pages.isEmpty()) { | ||
| FancyCorePlugin.get().getFancyLogger().error("No scoreboard pages loaded from storage!"); |
Member
There was a problem hiding this comment.
It's fine when no scoreboards exists. Maybe they don't want to use the scoreboard feature
| } | ||
| } | ||
|
|
||
| if (!cache.containsKey("default")) { |
Member
There was a problem hiding this comment.
"default" is not required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.