Add BSK-RL environment; fix indents on bulleted lists #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Biological / Medical environments | ||
| *Interacting with Biological Systems.* | ||
|
|
||
| - [ICU-Sepsis: A Benchmark MDP Built from Real Medical Data](https://github.com/icu-sepsis/icu-sepsis) | ||
|
|
||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
you are adding a bunch of spaces at the start of lines for some reason
current implementation looks fine to me
There was a problem hiding this comment.
This makes the content properly indented under the bullet as opposed to outdenting to body level after each bullet item, but happy to revert if that is preferred.
There was a problem hiding this comment.
Actually, it looks better that way, yeah, we can keep it, thanks.
| Highly scalable and customizable Safe Reinforcement Learning library. | ||
| Highly scalable and customizable Safe Reinforcement Learning library. | ||
|
|
||
| - [BSK-RL: Environments for Spacecraft Planning and Scheduling](https://avslab.github.io/bsk_rl/) |
There was a problem hiding this comment.
the envs are alphabetically sorted
|
Run precommit, More info on the contributing .md file |
|
Ran the precommit to resolve trailing whitespace. |
Kallinteris-Andreas
approved these changes
Sep 27, 2024
Kallinteris-Andreas
merged commit c8de1c7
into
Farama-Foundation:main
5 of 13 checks passed
|
ci is failing due to an unrelated issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the BSK-RL spacecraft tasking RL environment (https://avslab.github.io/bsk_rl/).
Also fixes indentation in the formatting on the external environments page so that bullets work correctly.
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)