Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue template #502

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
f1a106b
refactored project and removed v1 files/references/envs
reginald-mclean May 2, 2024
af157ff
fixing tests from refactor
reginald-mclean May 3, 2024
281a124
creating envs via gym.make
reginald-mclean Jul 24, 2024
3b7da2c
pre-commit
reginald-mclean Jul 24, 2024
a923060
fixing pre-commit
reginald-mclean Jul 24, 2024
31fd8e2
update to v3
reginald-mclean Jul 29, 2024
55ead70
updates
reginald-mclean Aug 13, 2024
7b7038a
moving wrappers to own folder, fixing ML10/ML45 env creation to match…
reginald-mclean Aug 29, 2024
54814df
Merge branch 'removeV1_refactor' of github.com:reginald-mclean/Metawo…
reginald-mclean Aug 29, 2024
cfecdaf
Merge branch 'reginald-mclean-removeV1_refactor'
reginald-mclean Aug 29, 2024
16480c0
pre-commit
reginald-mclean Aug 29, 2024
f9190f9
updating to use refactored MW
reginald-mclean Aug 30, 2024
2d953e3
updating gymnasium requirement to install alpha 2 (#482)
reginald-mclean May 24, 2024
4a315be
docs work (#483)
reginald-mclean May 27, 2024
def7959
Pages work (#484)
reginald-mclean May 27, 2024
de0000d
missing goal fixes (#485)
reginald-mclean Jul 3, 2024
8e29dd5
expert actions page
reginald-mclean Jul 29, 2024
3f953b9
updates
reginald-mclean Aug 13, 2024
5703841
pre-commit
reginald-mclean Aug 29, 2024
14df6bc
merging
reginald-mclean Aug 30, 2024
852ea81
pre-commit
reginald-mclean Aug 30, 2024
2b57f0e
pre-commit
reginald-mclean Aug 30, 2024
7d37933
pre-commit
reginald-mclean Aug 30, 2024
3cfbad0
pre-commit & type hinting
reginald-mclean Aug 30, 2024
3a1d74f
update action
reginald-mclean Aug 30, 2024
19f2062
type hinting
reginald-mclean Aug 30, 2024
99ba23a
type hinting again
reginald-mclean Aug 30, 2024
4c96658
type hinting again x 2
reginald-mclean Aug 30, 2024
eda5ba4
env-names in env-dict
reginald-mclean Aug 30, 2024
a63a024
updating paths
reginald-mclean Aug 30, 2024
0f8d38e
updating tests
reginald-mclean Aug 30, 2024
50f9a21
revert mt50 test classes = None
reginald-mclean Aug 30, 2024
35f20b6
adding issue templates
reginald-mclean Sep 5, 2024
2c2ba1a
Merge remote-tracking branch 'farama/master'
reginald-mclean Nov 6, 2024
af01000
Merge branch 'master' into issue_template
reginald-mclean Nov 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
48 changes: 48 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Bug Report
description: Submit a bug report
title: "[Bug Report] Bug title"
labels: ["bug"]
body:
- type: textarea
id: description
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is.
validations:
required: true

- type: textarea
id: code-example
attributes:
label: Code example
description: |
Please try to provide a minimal example to reproduce the bug. Error messages and stack traces are also helpful.
This will be automatically formatted into code, so no need for backticks.
render: shell

- type: textarea
id: system-info
attributes:
label: System info
description: |
Describe the characteristic of your environment:
* Describe how Gymnasium was installed (pip, docker, source, ...)
* Version of `gymnasium` (by `gymnasium.__version__`)
* What OS/version of Linux you're using. Note that while we will accept PRs to improve Window's support, we do not officially support it.
* Python version

- type: textarea
id: additional-context
attributes:
label: Additional context
description: Add any other context about the problem here.

- type: checkboxes
id: checklist
attributes:
label: Checklist
options:
- label: >
I have checked that there is no similar [issue](https://github.com/Farama-Foundation/Gymnasium/issues) in
the repo
required: true
49 changes: 49 additions & 0 deletions .github/ISSUE_TEMPLATE/proposal.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Proposal
description: Propose changes that are not fixing bugs
title: "[Proposal] Proposal title"
labels: ["enhancement"]
body:
- type: textarea
id: proposal
attributes:
label: Proposal
description: A clear and concise description of the proposal.
validations:
required: true

- type: textarea
id: motivation
attributes:
label: Motivation
description: |
Please outline the motivation for the proposal.
Is your feature request related to a problem? e.g.,"I'm always frustrated when [...]".
If this is related to another GitHub issue, please link here too.

- type: textarea
id: pitch
attributes:
label: Pitch
description: A clear and concise description of what you want to happen.

- type: textarea
id: alternatives
attributes:
label: Alternatives
description: A clear and concise description of any alternative solutions or features you've considered, if any.

- type: textarea
id: additional-context
attributes:
label: Additional context
description: Add any other context or screenshots about the feature request here.

- type: checkboxes
id: checklist
attributes:
label: Checklist
options:
- label: >
I have checked that there is no similar [issue](https://github.com/Farama-Foundation/Gymnasium/issues) in
the repo
required: true
21 changes: 21 additions & 0 deletions .github/ISSUE_TEMPLATE/question.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Question
description: Ask a question
title: "[Question] Question title"
labels: ["question"]
body:
- type: markdown
attributes:
value: >
If you're a beginner and have basic questions, please ask on
[r/reinforcementlearning](https://www.reddit.com/r/reinforcementlearning/) or in the
[RL Discord](https://discord.com/invite/xhfNqQv) (if you're new please use the beginners channel).
Basic questions that are not bugs or feature requests will be closed without reply, because GitHub
issues are not an appropriate venue for these. Advanced/nontrivial questions, especially in areas where
documentation is lacking, are very much welcome.
- type: textarea
id: question
attributes:
label: Question
description: Your question
validations:
required: true
24 changes: 12 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ You may wish to only access individual environments used in the Metaworld benchm

### Seeding a Benchmark Instance
For the purposes of reproducibility, it may be important to you to seed your benchmark instance.
For example, for the ML1 benchmark environment with the 'pick-place-v2' environment, you can do so in the following way:
For example, for the ML1 benchmark environment with the 'pick-place-V3' environment, you can do so in the following way:
```python
import metaworld

SEED = 0 # some seed number here
benchmark = metaworld.ML1('pick-place-v2', seed=SEED)
benchmark = metaworld.ML1('pick-place-V3', seed=SEED)
```

### Running ML1 or MT1
Expand All @@ -91,9 +91,9 @@ import random

print(metaworld.ML1.ENV_NAMES) # Check out the available environments

ml1 = metaworld.ML1('pick-place-v2') # Construct the benchmark, sampling tasks
ml1 = metaworld.ML1('pick-place-V3') # Construct the benchmark, sampling tasks

env = ml1.train_classes['pick-place-v2']() # Create an environment with task `pick_place`
env = ml1.train_classes['pick-place-V3']() # Create an environment with task `pick_place`
task = random.choice(ml1.train_tasks)
env.set_task(task) # Set task

Expand Down Expand Up @@ -152,15 +152,15 @@ environments respectively.

You can access them in the following way:
```python
from metaworld.envs import (ALL_V2_ENVIRONMENTS_GOAL_OBSERVABLE,
ALL_V2_ENVIRONMENTS_GOAL_HIDDEN)
from metaworld.envs import (ALL_V3_ENVIRONMENTS_GOAL_OBSERVABLE,
ALL_V3_ENVIRONMENTS_GOAL_HIDDEN)
# these are ordered dicts where the key : value
# is env_name : env_constructor

import numpy as np

door_open_goal_observable_cls = ALL_V2_ENVIRONMENTS_GOAL_OBSERVABLE["door-open-v2-goal-observable"]
door_open_goal_hidden_cls = ALL_V2_ENVIRONMENTS_GOAL_HIDDEN["door-open-v2-goal-hidden"]
door_open_goal_observable_cls = ALL_V3_ENVIRONMENTS_GOAL_OBSERVABLE["door-open-V3-goal-observable"]
door_open_goal_hidden_cls = ALL_V3_ENVIRONMENTS_GOAL_HIDDEN["door-open-V3-goal-hidden"]

env = door_open_goal_hidden_cls()
env.reset() # Reset environment
Expand All @@ -171,15 +171,15 @@ assert (obs[-3:] == np.zeros(3)).all() # goal will be zeroed out because env is
# You can choose to initialize the random seed of the environment.
# The state of your rng will remain unaffected after the environment is constructed.
env1 = door_open_goal_observable_cls(seed=5)
env2 = door_open_goal_observable_cls(seed=5)
enV3 = door_open_goal_observable_cls(seed=5)

env1.reset() # Reset environment
env2.reset()
enV3.reset()
a1 = env1.action_space.sample() # Sample an action
a2 = env2.action_space.sample()
a2 = enV3.action_space.sample()
next_obs1, _, _, _ = env1.step(a1) # Step the environment with the sampled random action

next_obs2, _, _, _ = env2.step(a2)
next_obs2, _, _, _ = enV3.step(a2)
assert (next_obs1[-3:] == next_obs2[-3:]).all() # 2 envs initialized with the same seed will have the same goal
assert not (next_obs2[-3:] == np.zeros(3)).all() # The env's are goal observable, meaning the goal is not zero'd out

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ COPY . /usr/local/metaworld/
WORKDIR /usr/local/metaworld/
RUN free -g
RUN pip install .[testing]
RUN git clone https://github.com/reginald-mclean/Gymnasium.git
RUN git clone https://github.com/Farama-Foundation/Gymnasium.git
RUN pip install -e Gymnasium


Expand Down
5 changes: 3 additions & 2 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ import random

print(metaworld.ML1.ENV_NAMES) # Check out the available environments

ml1 = metaworld.ML1('pick-place-v2') # Construct the benchmark, sampling tasks
ml1 = metaworld.ML1('pick-place-V3') # Construct the benchmark, sampling tasks

env = ml1.train_classes['pick-place-v2']() # Create an environment with task `pick_place`
env = ml1.train_classes['pick-place-V3']() # Create an environment with task `pick_place`
task = random.choice(ml1.train_tasks)
env.set_task(task) # Set task

Expand All @@ -41,6 +41,7 @@ obs, reward, terminate, truncate, info = env.step(a)
:caption: Introduction

introduction/basic_usage
evaluation/evaluation
installation/installation
rendering/rendering
usage/basic_usage
Expand Down
Loading
Loading