refactor: apply codacy suggestions

Farfetch · Dec 19, 2023 · 7e49ea2 · 7e49ea2
1 parent 22aef8c
commit 7e49ea2
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 11 deletions.
diff --git a/src/KafkaFlow.Retry.SqlServer/Readers/DboCollectionNavigator.cs b/src/KafkaFlow.Retry.SqlServer/Readers/DboCollectionNavigator.cs
@@ -24,7 +24,7 @@ public void Navigate(Action<TDomain> action, Predicate<TDbo> navigatingCondition
         Guard.Argument(action).NotNull();
         Guard.Argument(navigatingCondition).NotNull();
 
-        Navigate((domain, dbo) => action(domain), navigatingCondition);
+        Navigate((domain, _) => action(domain), navigatingCondition);
     }
 
     public void Navigate(Action<TDomain, TDbo> action, Predicate<TDbo> navigatingCondition)

diff --git a/src/KafkaFlow.Retry/Durable/Repository/Actions/Read/GetQueuesInput.cs b/src/KafkaFlow.Retry/Durable/Repository/Actions/Read/GetQueuesInput.cs
@@ -25,7 +25,7 @@ public GetQueuesInput(RetryQueueStatus status,
         {
             Guard.Argument(itemsStatuses, nameof(itemsStatuses))
                 .DoesNotContain(stuckStatusFilter.ItemStatus,
-                    (statuses, stuckStatus) =>
+                    (_, _) =>
                         "The status list can't contain the status that can be considered as stuck.");
         }
 

diff --git a/src/KafkaFlow.Retry/Durable/Repository/RetryDurableQueueRepository.cs b/src/KafkaFlow.Retry/Durable/Repository/RetryDurableQueueRepository.cs
@@ -63,7 +63,6 @@ public async Task<AddIfQueueExistsResult> AddIfQueueExistsAsync(IMessageContext
                 async () =>
                 {
                     return await AddIfQueueExistsAsync(
-                        context,
                         new SaveToQueueInput(
                             new RetryQueueItemMessage(
                                 context.ConsumerContext.Topic,
@@ -240,8 +239,7 @@ await Policy
         throw new ArgumentException($"None of the handlers is able to update the input {updateItemInput.GetType()}");
     }
 
-    private async Task<AddIfQueueExistsResult> AddIfQueueExistsAsync(IMessageContext context,
-        SaveToQueueInput saveToQueueInput)
+    private async Task<AddIfQueueExistsResult> AddIfQueueExistsAsync(SaveToQueueInput saveToQueueInput)
     {
         try
         {

diff --git a/src/KafkaFlow.Retry/Durable/RetryDurableMiddleware.cs b/src/KafkaFlow.Retry/Durable/RetryDurableMiddleware.cs
@@ -49,7 +49,7 @@ public async Task Invoke(IMessageContext context, MiddlewareDelegate next)
             .Handle<Exception>(exception => _retryDurableDefinition.ShouldRetry(new RetryContext(exception)))
             .WaitAndRetryAsync(
                 _retryDurableDefinition.RetryDurableRetryPlanBeforeDefinition.NumberOfRetries,
-                (retryNumber, c) =>
+                (retryNumber, _) =>
                     _retryDurableDefinition.RetryDurableRetryPlanBeforeDefinition.TimeBetweenTriesPlan(retryNumber),
                 (exception, waitTime, attemptNumber, c) =>
                 {

diff --git a/src/KafkaFlow.Retry/Forever/RetryForeverMiddleware.cs b/src/KafkaFlow.Retry/Forever/RetryForeverMiddleware.cs
@@ -24,8 +24,8 @@ public async Task Invoke(IMessageContext context, MiddlewareDelegate next)
         var policy = Policy
             .Handle<Exception>(exception => _retryForeverDefinition.ShouldRetry(new RetryContext(exception)))
             .WaitAndRetryForeverAsync(
-                (retryNumber, c) => _retryForeverDefinition.TimeBetweenTriesPlan(retryNumber),
-                (exception, attemptNumber, waitTime, c) =>
+                (retryNumber, _) => _retryForeverDefinition.TimeBetweenTriesPlan(retryNumber),
+                (exception, attemptNumber, waitTime, _) =>
                 {
                     if (!_controlWorkerId.HasValue)
                     {

diff --git a/src/KafkaFlow.Retry/Simple/RetrySimpleMiddleware.cs b/src/KafkaFlow.Retry/Simple/RetrySimpleMiddleware.cs
@@ -25,8 +25,8 @@ public async Task Invoke(IMessageContext context, MiddlewareDelegate next)
             .Handle<Exception>(exception => _retrySimpleDefinition.ShouldRetry(new RetryContext(exception)))
             .WaitAndRetryAsync(
                 _retrySimpleDefinition.NumberOfRetries,
-                (retryNumber, c) => _retrySimpleDefinition.TimeBetweenTriesPlan(retryNumber),
-                (exception, waitTime, attemptNumber, c) =>
+                (retryNumber, _) => _retrySimpleDefinition.TimeBetweenTriesPlan(retryNumber),
+                (exception, waitTime, attemptNumber, _) =>
                 {
                     if (_retrySimpleDefinition.PauseConsumer && !_controlWorkerId.HasValue)
                     {

diff --git a/tests/KafkaFlow.Retry.IntegrationTests/Core/Storages/InMemoryAuxiliarStorage.cs b/tests/KafkaFlow.Retry.IntegrationTests/Core/Storages/InMemoryAuxiliarStorage.cs
@@ -9,7 +9,7 @@ namespace KafkaFlow.Retry.IntegrationTests.Core.Storages;
 
 internal static class InMemoryAuxiliarStorage<T> where T : ITestMessage
 {
-    private const int TimeoutSec = 60;
+    private const int TimeoutSec = 90;
     private static readonly ConcurrentBag<T> s_message = new();
 
     public static bool ThrowException { get; set; }