feat: added default schema sql server db settings (#138)

Farfetch · Aug 30, 2023 · 8166355 · 8166355
1 parent 8f38d9c
commit 8166355
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/src/KafkaFlow.Retry.SqlServer/Repositories/RetryQueueItemMessageRepository.cs b/src/KafkaFlow.Retry.SqlServer/Repositories/RetryQueueItemMessageRepository.cs
@@ -44,7 +44,7 @@ public async Task<IList<RetryQueueItemMessageDbo>> GetMessagesOrderedAsync(IDbCo
                 entriesToLoad.Columns.Add("Id", typeof(int));
                 foreach (var retryQueueItemDbo in retryQueueItemsDbo)
                 {
-                    System.Data.DataRow dr = entriesToLoad.NewRow();
+                    var dr = entriesToLoad.NewRow();
                     dr["Id"] = retryQueueItemDbo.Id;
                     entriesToLoad.Rows.Add(dr);
                 }

diff --git a/src/KafkaFlow.Retry.SqlServer/RetryDurableDefinitionBuilderExtension.cs b/src/KafkaFlow.Retry.SqlServer/RetryDurableDefinitionBuilderExtension.cs
@@ -2,8 +2,6 @@
 {
     public static class RetryDurableDefinitionBuilderExtension
     {
-        private const string schemaDefault = "dbo";
-
         public static RetryDurableDefinitionBuilder WithSqlServerDataProvider(
             this RetryDurableDefinitionBuilder retryDurableDefinitionBuilder,
             string connectionString,
@@ -33,8 +31,7 @@ public static RetryDurableDefinitionBuilder WithSqlServerDataProvider(
                     .Create(
                         new SqlServerDbSettings(
                             connectionString,
-                            databaseName,
-                            schemaDefault)
+                            databaseName)
                     )
                 );
 

diff --git a/src/KafkaFlow.Retry.SqlServer/SqlServerDbSettings.cs b/src/KafkaFlow.Retry.SqlServer/SqlServerDbSettings.cs
@@ -10,8 +10,10 @@
     [ExcludeFromCodeCoverage]
     public class SqlServerDbSettings
     {
+        private const string schemaDefault = "dbo";
+
         /// <summary>
-        /// Creates a Sql Server database settings
+        /// Creates a Sql Server database settings with schema
         /// </summary>
         /// <param name="connectionString">The connection string of the Sql Server.</param>
         /// <param name="databaseName">The database name.</param>
@@ -27,6 +29,22 @@ public SqlServerDbSettings(string connectionString, string databaseName, string
             Schema = schema;
         }
 
+        /// <summary>
+        /// Creates a Sql Server database settings
+        /// </summary>
+        /// <param name="connectionString">The connection string of the Sql Server.</param>
+        /// <param name="databaseName">The database name.</param>
+
+        public SqlServerDbSettings(string connectionString, string databaseName)
+        {
+            Guard.Argument(connectionString).NotNull().NotEmpty();
+            Guard.Argument(databaseName).NotNull().NotEmpty();
+
+            ConnectionString = connectionString;
+            DatabaseName = databaseName;
+            Schema = schemaDefault;
+        }
+
         /// <summary>
         /// Gets the connection string of the Sql Server database.
         /// </summary>